Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashboard): remove obsolete js widget #6250

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Aug 9, 2024

We dropped support for <= 30 so we can drop the old frontend/js widget code.

Also addresses a warning from renovate:
grafik

@st3iny st3iny added 3. to review Waiting for reviews technical debt labels Aug 9, 2024
@st3iny st3iny self-assigned this Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.89%. Comparing base (401f674) to head (d97533d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6250      +/-   ##
============================================
+ Coverage     23.71%   23.89%   +0.18%     
+ Complexity      457      454       -3     
============================================
  Files           249      246       -3     
  Lines         11765    11651     -114     
  Branches       2211     2199      -12     
============================================
- Hits           2790     2784       -6     
+ Misses         8660     8551     -109     
- Partials        315      316       +1     
Flag Coverage Δ
javascript 15.46% <ø> (+0.16%) ⬆️
php 59.53% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny force-pushed the chore/remove-dead-dashboard-code branch from 15b350f to d97533d Compare August 13, 2024 08:08
@st3iny st3iny merged commit 096ff96 into main Aug 14, 2024
29 checks passed
@st3iny st3iny deleted the chore/remove-dead-dashboard-code branch August 14, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants